"Commit selected" removed from context menu

If you are having a problem using Vault, post a message here.

Moderator: SourceGear

davenovak
Posts: 222
Joined: Mon Jan 15, 2007 2:15 pm
Location: Atlanta, GA

"Commit selected" removed from context menu

Post by davenovak » Wed Dec 22, 2010 3:29 pm

Today we upgraded our Vault server (and all clients) from Vault 5.0.3 to 5.1.1. Though the upgrade itself was painless, a number of developers here have already commented on the fact that you can no longer select files in your Pending Change Set and then right-click to select Commit Selected. Why was this menu item removed?

This makes no sense to me, especially since Undo Selected and Shelve Selected are still part of this context menu.

Many of us here would really appreciate it if you would add that feature back to the Pending Change Set context menu.

Thank you!

lbauer
Posts: 9736
Joined: Tue Dec 16, 2003 1:25 pm
Location: SourceGear

Re: "Commit selected" removed from context menu

Post by lbauer » Thu Dec 23, 2010 6:13 am

Thanks for your feedback. If the user checks the files they want to checkin, then click the Commit command on the Pending Change set menu bar, then those selected items will be checked in.

But I can see where you might want to select a range without having the click each checkbox -- is that the case?
Linda Bauer
SourceGear
Technical Support Manager

davenovak
Posts: 222
Joined: Mon Jan 15, 2007 2:15 pm
Location: Atlanta, GA

Re: "Commit selected" removed from context menu

Post by davenovak » Thu Dec 23, 2010 7:27 am

So what you've done now is forced extra steps on the user to check in files. It is exactly as you say, you now must:
  • 1. Click the check box on the files you wish to check in
    2. Click the Commit button.
This is totally different than the way everyone I know has trained themselves to check in files using Vault. Those that I work with simply select a range of files from the list and then right-click and pick Commit Selected from the context menu. It's very fast and easy, but more importantly, it's how we all have done commits for the past 4+ years using Vault. Having to click the check boxes and then move the mouse all the way over to the Commit button feels like a real chore by contrast.

Frankly I'm just surprised that you removed a feature that was working perfectly well, only to replace it with one that is less efficient. Furthermore, as I stated in my previous post, I would point out that Undo Selected and Shelve Selected are still part of this context menu. So why not Commit Selected?!?

Please add 50 votes (user count in our office) for restoring this feature.

Thank you for listening.

lbauer
Posts: 9736
Joined: Tue Dec 16, 2003 1:25 pm
Location: SourceGear

Re: "Commit selected" removed from context menu

Post by lbauer » Thu Dec 23, 2010 10:45 am

I think some of the changes were primarily for new integration functionality in the Vault Pro client (selecting transactions to be associated with work items) But they appear to add extra steps in the Vault Standard Client.

I've logged work item 15793 to see how we can fix this in a future release.

Sorry for the inconvenience in the meantime.
Linda Bauer
SourceGear
Technical Support Manager

jclausius
Posts: 3601
Joined: Tue Dec 16, 2003 1:17 pm
Location: SourceGear
Contact:

Re: "Commit selected" removed from context menu

Post by jclausius » Thu Dec 23, 2010 4:21 pm

Dave,

In regards to your question of why...

In the next release of Vault, there will be an alternate treeview for change sets. Checkboxes work here as selecting / deselecting a tree node will modify files in that folder. At this point, a checkbox for selection in a listview will have the same meaning as a check in the treeview. The goal is to present a consistent UI across views. This also satisfied some complaints we had about losing the change set selections when inadvertently clicking the list.

I haven't seen negative feedback about the UI change until your post, but we aim to please. Perhaps there may be way that allows an either/or UI for change set items.

I'll have to think about this some more and see if there is a way to satisfy both conditions. Thanks for your feedback.
Jeff Clausius
SourceGear

davenovak
Posts: 222
Joined: Mon Jan 15, 2007 2:15 pm
Location: Atlanta, GA

Re: "Commit selected" removed from context menu

Post by davenovak » Mon Jan 03, 2011 10:03 am

Jeff --

As you evaluate various approaches that would allow an either/or UI for change set items, I would think that you could pretty much mimic the Undo Check Out... context menu behavior. In other words, when the user right-clicks in the Pending Change Set tab, the new Commit Selected... item would apply only to the highlighted items in the list (regardless of whether or not anything is actually checked).

That seems trivial to code, is very intuitive for the user, and seems to fit your either/or UI goal.

Hope this helps.

--Dave Novak

jclausius
Posts: 3601
Joined: Tue Dec 16, 2003 1:17 pm
Location: SourceGear
Contact:

Re: "Commit selected" removed from context menu

Post by jclausius » Mon Jan 03, 2011 10:28 am

Dave,

The check boxes for Vault can disappear, it's the case where the same class is being used with Vault Pro, and the selection is a bit trickier. I'll twiddle with some subclassing to see what shakes out.

Thanks for the feedback.
Jeff Clausius
SourceGear

davenovak
Posts: 222
Joined: Mon Jan 15, 2007 2:15 pm
Location: Atlanta, GA

Re: "Commit selected" removed from context menu

Post by davenovak » Wed Jan 05, 2011 9:13 am

I think it's also worth pointing out that the Search tab still contains a Check In... context menu option when you right-click on Edited items on the Search tab. Therefore, it doesn't seem like it would be hard to add the same back to the Pending Change Set tab.

jclausius
Posts: 3601
Joined: Tue Dec 16, 2003 1:17 pm
Location: SourceGear
Contact:

Re: "Commit selected" removed from context menu

Post by jclausius » Wed Jan 05, 2011 9:45 am

It's not a matter of technology, but rather what controls are in place. The pending changes list view control is coded differently than the list view control on the search results. As mentioned, there would need to be some new subclassing here.
Jeff Clausius
SourceGear

jclausius
Posts: 3601
Joined: Tue Dec 16, 2003 1:17 pm
Location: SourceGear
Contact:

Re: "Commit selected" removed from context menu

Post by jclausius » Wed Jan 05, 2011 9:47 am

You also raise a good point that there is an inconsistency between check boxes and selections in search results and the pending change set. I'll need to add that into the equation as well.

Thanks for bringing that up.
Jeff Clausius
SourceGear

davenovak
Posts: 222
Joined: Mon Jan 15, 2007 2:15 pm
Location: Atlanta, GA

Re: "Commit selected" removed from context menu

Post by davenovak » Wed Jan 05, 2011 10:00 am

Indeed -- the inconsistency between these tabs is really the most important thing to recognize.

joshyeager
Posts: 60
Joined: Wed Aug 18, 2004 11:15 am

Re: "Commit selected" removed from context menu

Post by joshyeager » Tue Jan 18, 2011 10:37 am

My users have noticed the same thing that Dave reported. In previous versions, if you had a lot of files checked out and wanted to check in five or ten of them, you could just shift-click on the first and last files, and then click Commit. Now, you have to check each file individually before you can commit them. It is also a bit annoying to have to click the Commit button instead of using the right-click menu.

jclausius
Posts: 3601
Joined: Tue Dec 16, 2003 1:17 pm
Location: SourceGear
Contact:

Re: "Commit selected" removed from context menu

Post by jclausius » Tue Jan 18, 2011 10:44 am

Josh,

Thanks for the feedback.
Jeff Clausius
SourceGear

iain.waddell
Posts: 45
Joined: Sun Mar 12, 2006 9:55 am

Re: "Commit selected" removed from context menu

Post by iain.waddell » Thu Feb 17, 2011 11:37 am

Add me to the list. It's been bugging me since I upgraded. It's just SO irritating.

As a partial workaround I've found using the VS2008 view allows me to commit but it only shows the files for the current solution, so it's not great if you've got to commit files outside of the solution.

Iain

iain.waddell
Posts: 45
Joined: Sun Mar 12, 2006 9:55 am

Re: "Commit selected" removed from context menu

Post by iain.waddell » Thu Feb 17, 2011 11:41 am

lbauer wrote: I've logged work item 15793 to see how we can fix this in a future release.
Is there any way we can follow the progress of this work item?

Iain

Post Reply